I occasionally get "ACPI shutdown failed" in qemu during tests. Since this is printed with grub_printf rather than with grub_dprintf or whatever, it shows up in the test output and causes tests to fail. It only fails some of the time on my system (less than half). I've tried to insert 'set debug=acpi' into the grub-shell test setup, but it stubbornly succeeds when I do that, so I'm not really sure what else to try.
The system seems to shut down happily anyway, presumably because it goes on to try other boot methods. Should we maybe downgrade this to a debug message? I've only seen this on Ubuntu, not on Debian, but I have no idea what's different about our qemu packaging. 2010-11-23 Colin Watson <cjwat...@ubuntu.com> * grub-core/commands/acpihalt.c (grub_acpi_halt): Downgrade "ACPI shutdown failed" to a debug message, since it can cause spurious test failures. === modified file 'grub-core/commands/acpihalt.c' --- grub-core/commands/acpihalt.c 2010-10-16 18:01:30 +0000 +++ grub-core/commands/acpihalt.c 2010-11-23 15:27:41 +0000 @@ -324,6 +324,6 @@ grub_acpi_halt (void) } } - grub_printf ("ACPI shutdown failed\n"); + grub_dprintf ("acpi", "ACPI shutdown failed\n"); } #endif Thanks, -- Colin Watson [cjwat...@ubuntu.com] _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel