On 25.03.2011 23:13, Mario Limonciello wrote: > + * util/grub-setup.c: Conditionalize the partition map copy on floppy > + support, not on whether the target contains partitions. > + > + Otherwise, the BIOS on Dell Latitude E series laptops will freeze > + during POST if an invalid partition table is contained in the PBR > + of the active partition when GRUB is installed to a partition. It's wrong to assume that no floppies contain partition tables. Also --allow-floppy is usually used for USB sticks which sometimes appear as floppies on some BIOSes and they pretty much contain the partition table. Bottom line is: if you see a partition table: preserve it. But it's ok to preserve this contents if floppy support is disabled even if no partition table is discovered. A small logic lecture:
Floppy support is: allow_floppy || grub_util_biosdisk_is_floppy (dest_dev->disk) Negation of it is either !(allow_floppy || grub_util_biosdisk_is_floppy (dest_dev->disk)) or !allow_floppy && !grub_util_biosdisk_is_floppy (dest_dev->disk), not what you wrote. Please don't move around unrelated parts. -- Regards Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/grub-devel
