On 31.01.2012 09:45, Richard Laager wrote:
Attached is a stack of trivial patches that apply*on top of* your
zfs.diff from 2012-01-29. They each deal with one logical change and
should be very easy to review.
After your original patch and this stack have been dealt with, I'll
submit an updated patch for native ZFS on Linux support, which is much
shorter than before.
--
Richard
zfs-on-linux-rlaager0.patch
Eliminate stray trailing spaces.
We don't do it manually, just from time to time run it automatically on
whole codebase.
zfs-on-linux-rlaager1.patch
Change device to devices in find_root_devices_from_libzfs
committed
zfs-on-linux-rlaager2.patch
Change strlen to sizeof
It doesn't matter since GCC changes strlen of const string to just a
const. But applied for conformity with the rest of codebase
zfs-on-linux-rlaager3.patch
Avoid crashing when canonicalize_file_name() fails
I could reproduce this with: grub-probe /dev/sda1
Committed
zfs-on-linux-rlaager4.patch
Drop an unused variable.
committed.
zfs-on-linux-rlaager5.patch
Add braces around and indent the `zpool status` parsing loop
Not needed. And we don't put a braces which are not needed.
zfs-on-linux-rlaager6.patch
Handle pool names with trailing spaces
What about the ones with spaces in the middle? It feels like the logic
is broken elsewhere and using strncmp is just a workaround which works
only for one particular case
zfs-on-linux-rlaager7.patch
Handle all raidz types in `zpool status` output
Committed.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
