On 22.04.2012 20:24, Samuel Thibault wrote:
> +     sprintf (devpath + strlen (devpath), "s%d", winner_part + 1);
> +    }
Also:
- It's probably wrong to assume that Hurd partition numbering is the
same as GRUB's, especially if several partmaps are present.
- Don't use x + strlen (x), keep pointer instead, you can easily do it
if you replace strcpy with stpcpy
- sprintf is banned in GRUB code. Use snprintf

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to