Vladimir 'φ-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 11:04:46 +0200, a écrit : > On 24.04.2012 01:34, Samuel Thibault wrote: > > +/* Retrieve the storage information for PATH, and search which partitions > > + * contains its start. */ > > +static char * > > +find_hurd_root_device (const char *path) > > +{ > > + struct store *path_store, *part_store; > > + char *devpath = NULL; > > + const char *prefix; > > + size_t len, prefix_len; > > + store_offset_t path_start; > > + int part; > > + > > + path_store = storeinfo_store (path); > > + if (! path_store) > > + grub_util_error ("Could not retrieve storage information for `%s'", > > path); > > + if (! path_store->name) > > + grub_util_error ("No storage name associated with `%s'", path); > grub_util_error messages should be marked for translation. And probably > have a TRANSLATORS comment about the context.
Ah, I had only had a look at the existing grub_util_info calls, which are not marked for translation. > > + if (first_run->start * part_store->block_size <= path_start && > > + (last_run->start + last_run->length) * part_store->block_size > > > path_start) { > Why this weird check rather than just check that start is the same? Because path_start is the start of the file, not of the partition containing the file. > Some partitions may contain more partitions, like logical container > contains logical partitions. Yes, but we do not have defined /dev namings for these yet, so we don't know how to look for them grom GRUB yet. Samuel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel