On Thu, Dec 12, 2013 at 07:48:05PM +0400, Andrey Borzenkov wrote: > > + Accept environment variables on the command line for Xen. > > Thank you! > > It may make sense to generalize it to other archs. At least EFI > definitely comes in mind. In this case platform specific part is only > to fetch parameter string(s). What about > > - move fetch_command_line_word and parse_command_line to separate file > that is included for specific platforms only > - make each platform that can accept fetch parameters in platform > specific way and call common code (parse_command_line) > > Does it make sense?
That might well be sensible, yes (multiboot too IIRC), but I was concerned about generalising this too early since some ports already have specialised requirements for command-line parsing - e.g. I think mipsel-loongson has some oddities. Maybe it would be best to do that kind of thing as a follow-up patch series? -- Colin Watson [cjwat...@ubuntu.com] _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
