ok, the fix is correct. This is why I always do size of typedefs. the
syntax is better.
On Fri, Jan 30, 2015 at 2:21 PM, Lennart Sorensen <
lsore...@csclub.uwaterloo.ca> wrote:
> On Fri, Jan 30, 2015 at 01:52:09PM -0700, Ben Hildred wrote:
> > Why do you want the size of a pointer instead of the size of the
> structure?
>
> Isn't *request_tag the dereferenced pointer, and hence is the size of
> the structure, where as before it was the size of a pointer?
>
> --
> Len Sorensen
>
> > On Fri, Jan 30, 2015 at 10:59 AM, Daniel Kiper <daniel.ki...@oracle.com>
> > wrote:
> >
> > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com>
> > > ---
> > > grub-core/loader/multiboot_mbi2.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/grub-core/loader/multiboot_mbi2.c
> > > b/grub-core/loader/multiboot_mbi2.c
> > > index 6f74aee..d7c19bc 100644
> > > --- a/grub-core/loader/multiboot_mbi2.c
> > > +++ b/grub-core/loader/multiboot_mbi2.c
> > > @@ -150,7 +150,7 @@ grub_multiboot_load (grub_file_t file, const char
> > > *filename)
> > > = (struct multiboot_header_tag_information_request *) tag;
> > > if (request_tag->flags & MULTIBOOT_HEADER_TAG_OPTIONAL)
> > > break;
> > > - for (i = 0; i < (request_tag->size - sizeof (request_tag))
> > > + for (i = 0; i < (request_tag->size - sizeof (*request_tag))
> > > / sizeof (request_tag->requests[0]); i++)
> > > switch (request_tag->requests[i])
> > > {
> > > --
> > > 1.7.10.4
> > >
> > >
> > > _______________________________________________
> > > Grub-devel mailing list
> > > Grub-devel@gnu.org
> > > https://lists.gnu.org/mailman/listinfo/grub-devel
> > >
> >
> >
> >
> > --
> > --
> > Ben Hildred
> > Automation Support Services
> > 303 815 6721
>
> > _______________________________________________
> > Grub-devel mailing list
> > Grub-devel@gnu.org
> > https://lists.gnu.org/mailman/listinfo/grub-devel
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
--
--
Ben Hildred
Automation Support Services
303 815 6721
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
