On Mon, Nov 21, 2016 at 08:22:41PM +0100, Alexander Graf wrote: > > Am 21.11.2016 um 20:10 schrieb Andrei Borzenkov <[email protected]>: > > 21.11.2016 18:23, Alexander Graf ?$B'a'Z'j'V'd: > >> We only support FDT files with EFI on arm and arm64 systems, not > >> on x86. So move the helper that finds a prepopulated FDT UUID > >> into its own file and only build it for architectures where it > >> also gets called. > >> > >> Signed-off-by: Alexander Graf <[email protected]> > >> > >> --- > >> > >> v1 -> v2: > >> > >> - Remove unused header includes > >> --- > >> grub-core/Makefile.core.def | 2 ++ > >> grub-core/kern/efi/fdt.c | 44 > >> ++++++++++++++++++++++++++++++++++++++++++++ > >> grub-core/kern/efi/init.c | 22 ---------------------- > >> include/grub/efi/efi.h | 2 ++ > >> 4 files changed, 48 insertions(+), 22 deletions(-) > >> create mode 100644 grub-core/kern/efi/fdt.c > >> > >> diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def > >> index 21ad0dd..2dfa22a 100644 > >> --- a/grub-core/Makefile.core.def > >> +++ b/grub-core/Makefile.core.def > >> @@ -212,8 +212,10 @@ kernel = { > >> > >> arm_efi = kern/arm/efi/init.c; > >> arm_efi = kern/arm/efi/misc.c; > >> + arm_efi = kern/efi/fdt.c; > >> > >> arm64_efi = kern/arm64/efi/init.c; > >> + arm64_efi = kern/efi/fdt.c; > >> > >> i386_pc = kern/i386/pc/init.c; > >> i386_pc = kern/i386/pc/mmap.c; > >> diff --git a/grub-core/kern/efi/fdt.c b/grub-core/kern/efi/fdt.c > >> new file mode 100644 > >> index 0000000..f74d505 > >> --- /dev/null > >> +++ b/grub-core/kern/efi/fdt.c > >> @@ -0,0 +1,44 @@ > >> +/* fdt.c - EFI Flattened Device Tree interaction */ > >> +/* > >> + * GRUB -- GRand Unified Bootloader > >> + * Copyright (C) 2006,2007 Free Software Foundation, Inc. > >> + * > > > > What about this one? This is new file so it should be 2016. > > As mentioned in the v1 reply, it's a split of an existing file, > so no new copyright was created. If you take a book and rip it > in half, copyright doesn't suddenly change either.
Make sense for me. If there are no more objections in 2-3 days I will apply this patch. Daniel _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
