On Wed, Jan 16, 2019 at 01:34:42PM -0500, Prarit Bhargava wrote: > grub_envblk_iterate() is a void. Future functions will require the > ability to interpret return codes from the iteration, so > grub_envblk_iterate() should be an int. > > The value of 0 returned from the hook functions is overloaded and cannot > be parsed by callers to grub_envblk_iterate() for error handling. To fix > this add GRUB_ERR_ITERATE_STOP and GRUB_ERR_ITERATE_CONTINUE to the error > returns so the iteration can be stopped and continued respectively. > > Make grub_envblk_iterate() return an int. > > Signed-off-by: Prarit Bhargava <pra...@redhat.com>
I do not like this patch. First of all GRUB errors are defined as an enum not as an int. The second: do not add error codes if they are not really needed. And yours are not needed at all. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
