On 3/13/20 8:15 PM, Javier Martinez Canillas wrote: > From: Hans de Goede <hdego...@redhat.com> > > On some devices the ESC key is the hotkey to enter the BIOS/EFI setup > screen, making it really hard to time pressing it right. Besides that > ESC is also pretty hard to discover for a user who does not know it > will unhide the menu. > > This commit makes F4, which used to be the hotkey to show the Windows > boot menu during boot for a long long time, also interrupt sleeps / > stop the menu countdown. >
Hans pointed me out that this part of the commit message is wrong after I modified his patch to use F4 as a hotkey instead of F8. I did this because that was decided in the previous version of this patch: https://lists.gnu.org/archive/html/grub-devel/2018-03/msg00136.html But F4 is not a hotkey used by Windows so this whole paragraph should be removed. And instead explain that F4 was chosen because is not used as a hotkey to enter the BIOS setup by any vendor. [snip] > +int > +grub_key_is_interrupt (int key) > +{ > + /* ESC sometimes is the BIOS setup hotkey and may be hard to discover, also > + check F4, which was the key to get the Windows bootmenu for a long > time. */ And this comment should also be fixed since is wrong now. I'll fix both issues on v2 but will wait first for review before doing that. Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel