Hello Daniel, On 4/3/20 6:40 PM, Daniel Kiper wrote:
[snip] >> >> I've also tested this outcome on a real Intel Xeon E3-1275v3 on an Intel >> Server Board S1200V3RPS using the SDV.RP.B8 "Release" build here: >> https://firmware.intel.com/sites/default/files/UEFIDevKit_S1200RP_vB8.zip >> >> Signed-off-by: Peter Jones <pjo...@redhat.com> >> Signed-off-by: Javier Martinez Canillas <javi...@redhat.com> > > It seems to me that this is very similar or even the same patch to > https://lists.gnu.org/archive/html/grub-devel/2018-02/msg00067.html > Yes. Since we have been carrying our patches for a long time, before posting any patch I search in the mailing list if it was previously proposed and try to address any issues that were pointed out there. In the future I'll explicit mention this and refer to the old thread if that's the case. > If yes I had some comments which were never resolved: > https://lists.gnu.org/archive/html/grub-devel/2018-02/msg00078.html > > If you take my comments into account I am happy to get it into 2.06. > I think that addressed most of them. I noticed now that I forgot to add some comments that you asked to explain why some values were chosen. I don't know the answer so I'll ask Peter about it and post a new version. > Daniel > Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel