On Sun, Dec 06, 2020 at 02:29:06PM +0100, Patrick Steinhardt wrote: > On Fri, Dec 04, 2020 at 10:43:34AM -0600, Glenn Washburn wrote: > > This allows code using these structs to know the named key associated with > > these json data structures. In the future we can use these to provide better > > error messages to the user. > > > > Get rid of idx variable in luks2_get_keyslot() which was overloaded to be > > used for both keyslot and segment slot keys. > > > > Signed-off-by: Glenn Washburn <[email protected]> > > Personally, I'd have named them `json_slot_idx`. But you've already done > so much work on improving the code that I don't want this to be the > reason to not give an SOB, especially considering that it's a strict > improvement anyway. So: > > Signed-off-by: Patrick Steinhardt <[email protected]>
I can change this to json_slot_idx before committing if Glenn does not object. Otherwise Reviewed-by: Daniel Kiper <[email protected]> Daniel _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
