On October 11, 2021 8:02:18 AM PDT, Daniel Kiper <dki...@net-space.pl> wrote: >On Thu, Oct 07, 2021 at 04:33:16PM -0700, Kees Cook wrote: >> GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's >> disk.number, which is an internal kernel index. If an array has had drives >> added, removed, etc, there may be gaps in GET_DISK_INFO's results. But >> since the consumer of devicelist cannot tolerate gaps (it expects to walk >> a NULL-terminated list of device name strings), the devicelist index (j) >> must be tracked separately from the disk.number index (i). >> >> As part of this, since grub wants to only examine active (i.e. present >> and non-failed) disks, the count of remaining disks (remaining) must be >> tracked separately from the devicelist index (j). >> >> Fixes: 49de079bbe1c ("... (grub_util_raid_getmembers): Handle "removed" >> disks") >> Fixes: 2b00217369ac ("... Added support for RAID and LVM") >> Fixes: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1912043 >> Fixes: https://savannah.gnu.org/bugs/index.php?59887 >> >> Signed-off-by: Kees Cook <k...@ubuntu.com> >> Reviewed-by: Petr Vorel <pvo...@suse.cz> > >You forgot to add a word about empty line change. I will do it for you.
Ah! Sorry, I had misunderstood what you'd asked for there. >So, Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com>... Thanks! >Thanks for fixing this. You're welcome. :) Who can commit this? (I don't have access.) -Kees -- Kees Cook _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel