On Fri, Feb 25, 2022 at 01:03:48PM +0100, Daniel Kiper wrote: > On Fri, Feb 25, 2022 at 11:33:09AM +0100, Javier Martinez Canillas wrote: > > Hello Peter, > > > > Thanks a lot for your patch. > > > > On 2/24/22 22:55, Peter Jones wrote: > > > ChangeLog-2015 has been untouched for over 7 years now, and any > > > information in it is purely for historical purposes. At the same time, > > > grepping for code winds up matching this file quite a bit, almost never > > > accomplishing anything other than cluttering up your grep results. We > > > don't need this in the main repo, and "git show" will find it if you're > > > looking at the old history of commits on some file. > > > > > > This patch deletes it. > > > > Yes, let's *please* get rid of this ChangeLog. It doesn't add any > > value AFAICT and makes doing greps over the codebase much harder. > > > > > Signed-off-by: Peter Jones <pjo...@redhat.com> > > > Reviewed-by: Daniel Axtens <d...@axtens.net> > > > Reviewed-by: Robbie Harwood <rharw...@redhat.com> > > > > Reviewed-by: Javier Martinez Canillas <javi...@redhat.com> > > I agree with above but it requires more than just ChangeLog-2015 file > removal. The file is referenced at least in Makefile.am.
I've sent a follow-up that fixes this as well. > Additionally, may we consider addition of a script which generates > ChangeLog file from the git log? I think we could steal it from here > [1][2]. Feel free, but IMO that's unrelated to this patch, which just cleans up old goo in the repo. > And if we do that I think we could drop NEWS file too (it is > referenced in README; so, it should be dropped from there too). Again, fine with me, but unrelated to this. ChangeLog-2015 is /in everyone's way/. -- Peter _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel