Diego Domingos <dieg...@linux.vnet.ibm.com> writes: > As a legacy support, if the vector 5 is not implemented, Power Hypervisor will > consider the max CPUs as 64 instead 256 currently supported during > client-architecture-support negotiation. > > This patch implements the vector 5 and set the MAX CPUs to 256 while setting > the > others values to 0 (default).
Ergh, CAS. I'm sorry I didn't check the defaults more carefully when I was at IBM! Anyway, this looks sane to me. I'm not in a position to test it any more, but it certainly follows the pattern I'd expect. And it is only likely to affect IBM machines anyway, so I think it's safe to add. > +struct option_vector5 { > + grub_uint8_t byte1; > + grub_uint8_t byte2; > + grub_uint8_t byte3; > + grub_uint8_t cmo; > + grub_uint8_t associativity; > + grub_uint8_t bin_opts; > + grub_uint8_t micro_checkpoint; > + grub_uint8_t reserved0; > + grub_uint32_t max_cpus; > +} __attribute__((packed)); > + I think the indent here should be 2 spaces? > + > struct pvr_entry { > grub_uint32_t mask; > grub_uint32_t entry; > @@ -512,6 +525,8 @@ struct cas_vector { > grub_uint16_t vec3; > grub_uint8_t vec4_size; > grub_uint16_t vec4; > + grub_uint8_t vec5_size; > + struct option_vector5 vec5; > } __attribute__((packed)); > > /* > @@ -534,7 +549,7 @@ grub_ieee1275_ibm_cas (void) > } args; > struct cas_vector vector = { > .pvr_list = { { 0x00000000, 0xffffffff } }, /* any processor */ > - .num_vecs = 4 - 1, > + .num_vecs = 5 - 1, > .vec1_size = 0, > .vec1 = 0x80, /* ignore */ > .vec2_size = 1 + sizeof(struct option_vector2) - 2, > @@ -545,6 +560,10 @@ grub_ieee1275_ibm_cas (void) > .vec3 = 0x00e0, /* ask for FP + VMX + DFP but don't halt if unsatisfied > */ > .vec4_size = 2 - 1, > .vec4 = 0x0001, /* set required minimum capacity % to the lowest value */ > + .vec5_size = 1 + sizeof(struct option_vector5) - 2, > + .vec5 = { > + 0, 0, 0, 0, 0, 0, 0, 0, 256 This maybe should be indented 6 spaces instead of 1 tab? But I wouldn't do a whole new revision just for this. Acked-by: Daniel Axtens <d...@axtens.net> Kind regards, Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel