On Fri, Mar 31, 2023 at 02:01:10PM +0800, Xiaotian Wu wrote: Missing commit message. Almost every patch has to have commit message which describes what it does, why and how (proportions of these things may vary from patch to patch). Proper subject is usually not enough. Please fix this here and in subsequent patches...
> Signed-off-by: Xiaotian Wu <wuxiaot...@loongson.cn> > Signed-off-by: Zhou Yang <zhouy...@loongson.cn> I expect Zhou first worked on the patch and than Xiaotian taken over the work. If this is true then SOB should be sorted in the following way: Signed-off-by: Zhou Yang <zhouy...@loongson.cn> Signed-off-by: Xiaotian Wu <wuxiaot...@loongson.cn> Usually sender is at the end of the list... Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
