On 06.10.2023 21:21, Glenn Washburn wrote:
Commit messages should not use links to downstream projects. The commit hash referred to in that link does not exist in GRUB master. Here's a more appropriate link:https://git.savannah.gnu.org/cgit/grub.git/tree/grub-core/disk/i386/pc/biosdisk.c?h=grub-2.12-rc1#n430See: https://github.com/geneC/syslinux/blob/5e426532210bb830d2d7426eb8d8c154d9dfcba6/core/fs/diskio_bios.c#L349I would also change this to link to the official syslinux repository, not an unofficial mirror that may be gone tomorrow. I'd use this link instead: https://repo.or.cz/syslinux.git/blob/refs/tags/syslinux-6.03:/core/fs/diskio_bios.c#l349
Indeed, I just took the first links without validation, thanks.I'll wait for other comments, and if there aren't any, will send updated patchset.
Note that 63 vs 127 patch (2/2) have only marginal speedup and thus not that important. Since it causes lots of questions and fear of breaking things from you and Vladimir, I guess we should just not apply it.
OpenPGP_signature
Description: OpenPGP digital signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
