On Mon, Nov 06, 2023 at 08:43:29PM +0100, Vladimir 'phcoder' Serbinenko wrote: > Le lun. 6 nov. 2023, 18:04, Daniel Kiper <dki...@net-space.pl> a écrit : > On Tue, Oct 31, 2023 at 08:20:14PM +0100, Vladimir 'phcoder' > Serbinenko wrote: > > From 9d03ab04df3b723058fb0b7c30576e1330cbad5d Mon Sep 17 00:00:00 > 2001 > > From: Vladimir Serbinenko <phco...@gmail.com> > > Date: Tue, 31 Oct 2023 18:27:19 +0100 > > Subject: [PATCH] acpi: Mark MADT entries as packed. > > > > No alignment is guaranteed and in fact on my ia64 sapic is aligned > > to 4 bytes instead of 8 and causes a trap. It affects only rarely > used > > lsacpi command and so went unnoticed. > > At least you missed grub_acpi_madt_entry_header struct. It should > have > packed attribute too. > Nope. It has only uint8. So no need for packed
Sorry, I did not take a look at the types. Yeah, you are right. This will not change anything. Though I would add it to align struct definitions with others. Lack of packed attribute is a bit confusing at first sight. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
