On Wed, Aug 14, 2024 at 05:40:08PM +0200, Daniel Kiper wrote: > On Fri, Jun 28, 2024 at 04:18:47PM +0800, Gary Lin via Grub-devel wrote: > > Remove _asn1_strcat() and replace strcat() with the bound-checked > > _asn1_str_cat() except the one inside _asn1_str_cat(). That strcat > > s/strcat/strcat()/ > > > is replaced with strcpy. > > s/strcpy/strcpy()/ > Will fix them in the next version.
> This commit message and one below miss explanation why these changes are > needed. Ok, I'll add more details about the change. > And I think this patch should be split into two... The changes are all about the same thing: replacing strcat() with a bound-checked function. What kind of splitting woud you suggest? Gary Lin > > > Signed-off-by: Daniel Axtens <d...@axtens.net> > > Signed-off-by: Gary Lin <g...@suse.com> > > --- > > ...asn1-use-bound-checked-_asn1_str_cat.patch | 85 +++++++++++++++++++ > > 1 file changed, 85 insertions(+) > > create mode 100644 > > grub-core/lib/libtasn1-patches/0002-libtasn1-use-bound-checked-_asn1_str_cat.patch > > > > diff --git > > a/grub-core/lib/libtasn1-patches/0002-libtasn1-use-bound-checked-_asn1_str_cat.patch > > > > b/grub-core/lib/libtasn1-patches/0002-libtasn1-use-bound-checked-_asn1_str_cat.patch > > new file mode 100644 > > index 000000000..87bb13e06 > > --- /dev/null > > +++ > > b/grub-core/lib/libtasn1-patches/0002-libtasn1-use-bound-checked-_asn1_str_cat.patch > > @@ -0,0 +1,85 @@ > > +From d87d8e78371e3afbdd876193295ab9e3f60c140b Mon Sep 17 00:00:00 2001 > > +From: Gary Lin <g...@suse.com> > > +Date: Tue, 25 Jun 2024 16:27:57 +0800 > > +Subject: [PATCH 2/6] libtasn1: use bound-checked _asn1_str_cat() > > + > > +Remove _asn1_strcat() and replace strcat() with the bound-checked > > +_asn1_str_cat() except the one inside _asn1_str_cat(). That strcat > > +is replaced with strcpy. > > + > > +Signed-off-by: Daniel Axtens <d...@axtens.net> > > +Signed-off-by: Gary Lin <g...@suse.com> > > Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
