On Tue, Apr 01, 2025 at 03:58:57PM +0300, Vladimir Serbinenko wrote:
Please split this patch into (probably) three and add CID to each one.
Good example is in commit 4dc616657 (loader/i386/bsd: Use safe math to
avoid underflow). Of course patches should land in
grub-core/lib/libgcrypt-patches.
Did you report these issues to libgcrypt maintainers?
And...
Applying: libgcrypt: Fix coverity warnings
.git/rebase-apply/patch:17: space before tab in indent.
int n = (a->sign+7)/8;
.git/rebase-apply/patch:18: space before tab in indent.
void *p = _gcry_is_secure(a->d)? xtrymalloc_secure (n)
.git/rebase-apply/patch:23: space before tab in indent.
memcpy( p, a->d, n );
.git/rebase-apply/patch:24: space before tab in indent.
b = mpi_set_opaque( NULL, p, a->sign );
.git/rebase-apply/patch:33: trailing whitespace.
warning: squelched 2 whitespace errors
warning: 7 lines add whitespace errors.
By the way, when I run bootstrap I can these warnings:
Importing libgcrypt...
WARNING: C file isn't a module: blake2.c
WARNING: C file isn't a module: ecc-curves.c
WARNING: C file isn't a module: ecc-ecdh.c
WARNING: C file isn't a module: ecc-ecdsa.c
WARNING: C file isn't a module: ecc-eddsa.c
WARNING: C file isn't a module: ecc-gost.c
WARNING: C file isn't a module: ecc-misc.c
WARNING: C file isn't a module: ecc-sm2.c
WARNING: C file isn't a module: gost-s-box.c
WARNING: C file isn't a module: poly1305.c
WARNING: C file isn't a module: primegen.c
Daniel
_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
