On Tue, Jun 24, 2025 at 01:32:24PM -0600, Leo Sandoval via Grub-devel wrote:
> Containers bring the ability to have ready-to-use environments and in
> this case complete Fedora and Debian container files are described
> containing all required packages for building and testing grub2.

The project name is GRUB not grub, grub2 or what not...

> Once users manually build it, they can run the desired container, jump
> into a setup ready for development. On the other hand, if users
> prefer to use bare metal instead of a containerized environment, it is
> still useful to have a file explicitly indicating the required packages.

The packages list should be documented in the INSTALL file. The
containers files should be in sync with that file. Maybe even this
should be mentioned in the INSTALL and container files. We should not
treat container files as a documentation...

> Signed-off-by: Leo Sandoval <lsand...@redhat.com>
> ---
>  INSTALL                        | 39 +++++++++++++++++++++++
>  container/Containerfile.debian | 56 +++++++++++++++++++++++++++++++++
>  container/Containerfile.fedora | 57 ++++++++++++++++++++++++++++++++++
>  3 files changed, 152 insertions(+)
>  create mode 100644 container/Containerfile.debian
>  create mode 100644 container/Containerfile.fedora
>
> diff --git a/INSTALL b/INSTALL
> index 724584c575..8aaee7f7f6 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -354,3 +354,42 @@ operates.
>  `--version'
>       Print the version of Autoconf used to generate the `configure'
>       script, and exit.
> +
> +Container
> +==========
> +
> +Containers bring the ability to have ready-to-use environments isolated 
> completely
> +from the build environment. Under the 'container' folder, there are 
> container files
> +(Containerfile.*) which describe images ready for building and testing grub2.
> +
> +Once users manually build it (see next section), they can run the desired 
> container, jump
> +into a setup ready for development. On the other hand, if users prefer to 
> use bare metal
> +instead of a containerized environment, it is still useful to have a file 
> explicitly
> +indicating the required packages.

I would drop this paragraph.

> +Container usage
> +================
> +
> +Assuming your build OS support containers, e.g. all Linux distros, install 
> 'podman' on
> +your favorite distro then build a specific image with
> +
> +  $ podman build -t fedora-grub -f Containerfile.fedora .
> +
> +or in case you prefer Debian
> +
> +  $ podman build -t debian-grub -f Containerfile.debian .
> +
> +once built, you can run/launch any of the aboven
> +
> +  $ podman run -it fedora-grub

Please add a list of Fedora packages to the INSTALL file in the similar
way how it is done for Debian. I understand they are very similar but
AFAICT there are couple of differences...

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to