> On 4 Jul 2025, at 8:48 PM, Frediano Ziglio <frediano.zig...@cloud.com> wrote:
>
> On Fri, Jul 4, 2025 at 4:13 PM Sudhakar Kuppusamy
> <sudha...@linux.ibm.com> wrote:
>>
>>
>>
>>> On 4 Jul 2025, at 7:35 PM, Frediano Ziglio via Grub-devel
>>> <grub-devel@gnu.org> wrote:
>>>
>>> More readable, could consume less space.
>>>
>>> Signed-off-by: Frediano Ziglio <frediano.zig...@cloud.com>
>>> ---
>>> grub-core/loader/arm64/xen_boot.c | 14 +++++++-------
>>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/grub-core/loader/arm64/xen_boot.c
>>> b/grub-core/loader/arm64/xen_boot.c
>>> index 731f1913a..8db1d9db0 100644
>>> --- a/grub-core/loader/arm64/xen_boot.c
>>> +++ b/grub-core/loader/arm64/xen_boot.c
>>> @@ -67,7 +67,7 @@ struct xen_boot_binary
>>> {
>>> struct xen_boot_binary *next;
>>> struct xen_boot_binary **prev;
>>> - int is_hypervisor;
>>> + bool is_hypervisor;
>>
>>
>> Something is off with indention here
>>>
>>> grub_addr_t start;
>>> grub_size_t size;
>>> @@ -79,7 +79,7 @@ struct xen_boot_binary
>>>
>>> static grub_dl_t my_mod;
>>>
>>> -static int loaded;
>>> +static bool loaded;
>> Something is off with indention here
>>>
>>> static struct xen_boot_binary *xen_hypervisor;
>>> static struct xen_boot_binary *module_head;
>>> @@ -306,7 +306,7 @@ all_binaries_unload (void)
>>> static grub_err_t
>>> xen_unload (void)
>>> {
>>> - loaded = 0;
>>> + loaded = false;
>>
>> Something is off with indention here
>>
>>> all_binaries_unload ();
>>> grub_fdt_unload ();
>>> grub_dl_unref (my_mod);
>>> @@ -410,7 +410,7 @@ grub_cmd_xen_module (grub_command_t cmd
>>> __attribute__((unused)),
>>> if (!module)
>>> return grub_errno;
>>>
>>> - module->is_hypervisor = 0;
>>> + module->is_hypervisor = false;
>>> module->align = 4096;
>>>
>>> grub_dprintf ("xen_loader", "Init module and node info\n");
>>> @@ -466,7 +466,7 @@ grub_cmd_xen_hypervisor (grub_command_t cmd
>>> __attribute__ ((unused)),
>>> if (!xen_hypervisor)
>>> return grub_errno;
>>>
>>> - xen_hypervisor->is_hypervisor = 1;
>>> + xen_hypervisor->is_hypervisor = true;
>> Same here.
>>> xen_hypervisor->align
>>> = (grub_size_t) lh.pe_image_header.optional_header.section_alignment;
>>>
>>> @@ -474,7 +474,7 @@ grub_cmd_xen_hypervisor (grub_command_t cmd
>>> __attribute__ ((unused)),
>>> if (grub_errno == GRUB_ERR_NONE)
>>> {
>>> grub_loader_set (xen_boot, xen_unload, 0);
>>> - loaded = 1;
>>> + loaded = true;
>> Same here.
>>> }
>>>
>>> fail:
>>> @@ -482,7 +482,7 @@ fail:
>>> grub_file_close (file);
>>> if (grub_errno != GRUB_ERR_NONE)
>>> {
>>> - loaded = 0;
>>> + loaded = false;
>>
>> same here
>>
>> Thanks,
>> Sudhakar
>>> all_binaries_unload ();
>>> grub_dl_unref (my_mod);
>>> }
>
> None on my side. Are you sure it's not a question of your fonts?
Thanks Frediano. It seems issue with fonts.
Reviewed-by: Sudhakar Kuppusamy <sudha...@linux.ibm.com
<mailto:sudha...@linux.ibm.com>>
>
> Frediano
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
