"cmdline_size" already account for NUL terminator, you can see
this in "xen_boot_binary_load".
The same property is set correctly for Xen command line.

Signed-off-by: Frediano Ziglio <frediano.zig...@cloud.com>
---
 grub-core/loader/arm64/xen_boot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grub-core/loader/arm64/xen_boot.c 
b/grub-core/loader/arm64/xen_boot.c
index 14afec143..ed22b49e0 100644
--- a/grub-core/loader/arm64/xen_boot.c
+++ b/grub-core/loader/arm64/xen_boot.c
@@ -174,7 +174,7 @@ prepare_xen_module_params (struct xen_boot_binary *module, 
void *xen_boot_fdt)
                    module->cmdline, module->cmdline, module->cmdline_size);
 
       retval = grub_fdt_set_prop (xen_boot_fdt, module_node, "bootargs",
-                                 module->cmdline, module->cmdline_size + 1);
+                                 module->cmdline, module->cmdline_size);
       if (retval)
        return grub_error (GRUB_ERR_IO, "failed to update FDT");
     }
-- 
2.43.0


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to