On Thu, Oct 16, 2025 at 08:29:40PM +0200, Daniel Kiper wrote:
> On Thu, Oct 16, 2025 at 02:51:48PM +0800, Michael Chang via Grub-devel wrote:
[snip]
> > +
> > +/*
> > + * fs_envblk_spec describes the file-system specific layout of reserved raw
> > + * blocks used as environment blocks. At present only Btrfs is supported.
> > Other
> > + * file-systems may be added if they provide a similar facility and avoid
> > the
> > + * limitation of writing to COW.
> > + *
> > + * Note: If this table is modified, also update
> > + * grub-core/fs/btrfs.c::btrfs_head, which defines the layout in the Btrfs
> > + * header and exports GRUB_ENV_BTRFS_OFFSET, so that both stay consistent.
> > + */
> > +static fs_envblk_spec_t fs_envblk_spec[] __attribute__ ((unused)) = {
> > + { "btrfs", GRUB_ENV_BTRFS_OFFSET, GRUB_DISK_SECTOR_SIZE },
>
> Only this line form this hunk belongs to this patch. The typedef and
> variable definition should be moved to next patch (yeah, the framework
> should do nothing until Btrfs patch is applied). And this patch should
> be last one adding Btrfs support to fully ready envblk framework.
I have just sent v6 for review with the suggested changes made, please
help to take a look.
Thanks,
Michael
>
> > + { NULL, 0, 0 }
> > +};
>
> Daniel
_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
