On Thu, Oct 02, 2025 at 05:54:47PM +0200, Daniel Kiper wrote:
> On Thu, Oct 02, 2025 at 02:46:18PM +0800, Michael Chang via Grub-devel wrote:
> > This patch updates unset_variables so that removals are also applied to
> 
> Again s/unset_variables/unset_variables()/...

OK, will fix next version.

> 
> > the external environment block when it is present. The code opens the
> > external block, deletes the same named keys there, and then writes the
> > external block back using fs_envblk_write. The file based envblk is
> > still updated and written as before.
> >
> > Signed-off-by: Michael Chang <[email protected]>
> > Reviewed-by: Neal Gompa <[email protected]>
> > Reviewed-by: Avnish Chouhan <[email protected]>
> > ---
> >  util/grub-editenv.c | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/util/grub-editenv.c b/util/grub-editenv.c
> > index efc6ec5f2..ad3088475 100644
> > --- a/util/grub-editenv.c
> > +++ b/util/grub-editenv.c
> > @@ -476,18 +476,32 @@ static void
> >  unset_variables (const char *name, int argc, char *argv[])
> >  {
> >    grub_envblk_t envblk;
> > +  grub_envblk_t envblk_fs = NULL;
> 
> s/envblk_fs/envblk_on_block/?

OK, will fix next version.

Thanks,
Michael

> 
> Daniel

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to