On 2025-10-13 15:26, John Paul Adrian Glaubitz wrote:
Hello Avnish,
On Mon, 2025-10-13 at 15:09 +0530, Avnish Chouhan wrote:
diff --git a/util/grub-install.c b/util/grub-install.c
index 0602465..f7389b3 100644
--- a/util/grub-install.c
+++ b/util/grub-install.c
@@ -1289,6 +1289,19 @@ main (int argc, char *argv[])
is_prep = 0;
}
}
+#if defined(__powerpc__)
+ else
+ {
+ /*
+ * As the machine has been detected as PowerPC and not the
PowerMac. We need to check
I have not looked at the patch context here, so I'm just asking: Where
are you checking that the
target machine is not a PowerMac where installation isn't performed on
a device but into a directory?
Should there be a check whether --macppc-directory is set?
Hi Adrian,
The code block just above this "if (macppcdir)......" checks whether the
machine is a "PowerMac" or not a "PowerMac". We have just added the else
part of "if (macppcdir)" !
Thank you!
Regards,
Avnish Chouhan
Also, minor nitpick: It should be just "As the machine has been
detected as PowerPC and not a PowerMac".
+ * whether the install_device has been mentioned while installing.
If no device has been
+ * mentioned, we need to exit and mark it as an error as the
install_device is required for
+ * PowerPC installation. An installation with no device mentioned
may lead to corruptions.
+ */
+ if (!install_device)
+ grub_util_error ("%s", _("install device isn't specified
required for PowerPC"));
+ }
+#endif /* __powerpc__ */
}
size_t ndev = 0;
Adrian
_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
