On 2025-10-02 11:23, Michael Chang wrote:
Hi Avnish,
Thanks a not for the review, please check my comments below.
On Wed, Sep 17, 2025 at 04:34:52PM +0530, Avnish Chouhan wrote:
On 2025-09-15 14:39, [email protected] wrote:
> Message: 4
> Date: Mon, 15 Sep 2025 17:08:42 +0800
> From: Michael Chang <[email protected]>
> To: The development of GNU GRUB <[email protected]>
> Cc: Neal Gompa <[email protected]>, Marta Lewandowska
> <[email protected]>
> Subject: [PATCH v2 3/9] util/grub-editenv: add fs_envblk write helper
> Message-ID: <[email protected]>
>
> This patch adds the function fs_envblk_write to update the reserved
> environment block on disk. The helper takes an in memory envblk buffer
> and writes it back to the device at the location defined by the
> fs_envblk specification. It performs size checks and uses file sync to
> ensure that the updated data is flushed.
>
> The helper is also added into the fs_envblk ops table, together with the
> open helper from the previous patch. With this change the basic input
> and output path for an external environment block is complete. The
> choice of which variables should be written externally will be handled
> by later patches.
>
> Signed-off-by: Michael Chang <[email protected]>
Reviewed-by: Avnish Chouhan <[email protected]>
_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
