On Mon, Nov 24, 2025 at 8:14 AM, Radoslav Kolev <[email protected]> wrote: > On Mon, Nov 24, 2025 at 1:49 PM Daniel Kiper <[email protected]> wrote: > > I am not convinced we have to have this. I want to hear other folks > > opinion here. If you convince me to have this behavior for these > > commands I think this exception have to be documented in the GRUB > > documentation. > > I have found myself sometimes forgetting to add the -p, so for example having > something like "blscfg (hd0,gpt2)/..." instead of "blscfg -p (hd0,gpt2)/..." > and > taking me a while to figure out why things didn't work as I expected them to. > > Coincidentally, this was the way a path was supposed to be passed to the > implementation of the same command in the earlier versions of these patches. > My logic was that it's better to error out explicitly when an > unsupported argument > is passed instead of just ignoring it silently, but let's see what others > think. > > Thank you for the quick response and I'll prepare a new revision when > a decision is > made to keep this functionality or not. > > Best regards, > Radoslav
I'm not opposed to erroring out when receiving an argument without an option prior, but if it is preferred to maintain the current behavior, we could print a debug message instead of an error to indicate the command doesn't take standalone arguments. That way it won't be silently ignored if someone else runs into the same issue. Alec Brown _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
