This patch removes unused define which was left after...

Erin Yueh wrote:
Paulius Zaleckas wrote:
I have also removed lgsm_get_info declaration since we are not going to use it according to Sean Chiang.

Regards,
Paulius Zaleckas
------------------------------------------------------------------------

Hi Paulius,
Thanks for your patches! I modified some parts to fit gsmd design. Actually, we don't need to keep the phone information in gsmd and needn't to retrieve them in initial settings. Why we store IMSI value in gsmd, it's for bug#1185. Also, if you are interested in more detailed 'gsmd', you may read http://wiki.openmoko.org/wiki/Gsmd/document wiki page.

Hi List,

R4066 is committed for fix atcmd buffer length. R4067 is committed for retrieving phone information. Regards,
Erin


Index: include/gsmd/gsmd.h
===================================================================
--- include/gsmd/gsmd.h	(revision 4067)
+++ include/gsmd/gsmd.h	(working copy)
@@ -73,7 +73,6 @@
 #define GSMD_FLAG_SMS_FMT_TEXT	0x0002	/* TODO Use TEXT rather than PDU mode */
 
 #define GSMD_ATCMD_TIMEOUT	60	/* If doesn get respond within 60 secs, discard */
-#define GSMD_MAX_INFO_LEN	64	/* by the standard it should be 2048, way too much :) */
 
 struct gsmd {
 	unsigned int flags;

Reply via email to