Hi Nikolaus, On Mon, 25 Jan 2016 18:07:04 +0100 "H. Nikolaus Schaller" <[email protected]> wrote:
> Hi Andreas, > > Am 24.01.2016 um 22:27 schrieb H. Nikolaus Schaller <[email protected]>: > > > Hi Andreas, > > > > Am 24.01.2016 um 21:22 schrieb Andreas Kemnade <[email protected]>: > > > >> Hi, > >> > >> I have done some further analysis: > >> > >> On Sat, 23 Jan 2016 23:08:01 +0100 > >> "H. Nikolaus Schaller" <[email protected]> wrote: > >> > >>> > >>> Am 23.01.2016 um 19:03 schrieb Andreas Kemnade <[email protected]>: > >>> > >>>> Hi, > >>>> > >>>> On Sat, 23 Jan 2016 13:13:03 +0100 > >>>> "H. Nikolaus Schaller" <[email protected]> wrote: > >>>> > >>>>> Hi, > >>>>> > >>>>> Am 23.01.2016 um 11:36 schrieb Andreas Kemnade <[email protected]>: > >>>>> > >>>>>> Hi, > >>>>>> > >>>>>> I found out that there is stuff in letux-base which is not upstreamed. > >>>>>> Is everything there considered not upstreamable? What is considered a > >>>>>> good fix and what not? > >>>>> > >>>>> Well, some things in letux-base are purely historical and inherited > >>>>> from 3.7-neil... > >>>>> So they might be wrong today. > >>>>> > >>>> That is all 2013/2014. So it is not that historcal > >>>> > >>>> $ git shortlog --no-merges v4.4...goldelico2/letux-base -- > >>>> drivers/net/wireless/libertas > >>>> Dan Williams (1): > >>>> libertas/sdio: fix releasing memory twice. > >>>> > >> superseeded by > >> libertas: move firmware lifetime handling to firmware.c > >> 1dfba3060fe7ee03ccec25a91d35085142dfc295 > >> probably merged with that to the proper thing. > > > > I think merging something twice is not harmful. > > > > We probably cherry-picked a preliminary version which was changed on its way > > through linux-next to linus/master. > > > >> > >> > >>>> NeilBrown (4): > >>>> libertas/sdio: make sure card enters power-off when firmware is > >>>> loaded. > >> > >> falso alert > >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/net/wireless/libertas/if_sdio.c?id=d94248ac2aef78e39a76321458a78ba7805dba2e > >>>> libertas - hack to fix suspend. required, looks sane but not complete yet, reason: drivers/mmc/core/core.c changed. The card is now only removed if the sdio card driver does not have suspend/resume functions. pre_suspend in sdio.c returns ENOSYS then which is called in core.c > >>>> libertas/sdio: make power management dependant on > >>>> MMC_CAP_POWER_OFF_CARD > >>>> libertas/sdio: simplify suspend/resume. > >>>> does not seem to work without. It is unclear whether that is the proper fix. > >> These things are not upstreamed and require more analysis. > >> I will check these. > >> Still waiting to be ported from my 3.7-neil-plus-plus: > >> 8b9da484f3f4e7129debf887f373dd2d95f96068 > >> wireless:libertas: fix race conditions on resume > >> That is definitively needed in recent kernels. > > > > I have cherry-picked and fixed 3 merge conflicts. Two appeared to be easy > > but one (if_sdio_power_restore) > > wasn't. Please look into it when I push the merge results in the next days. > I think I can better make use of the waitqueue in if_sdio.c to have it even simpler. > Ok, here it is: > > http://git.goldelico.com/?p=gta04-kernel.git;a=shortlog;h=refs/heads/work/kemnade/wifi-sdio-fixes > I have put together the stuff at https://github.com/akemnade/linux/tree/work/kemnade/wifi-sdio-fixes-v3 For now, that power management fix is not in. As it touches code which is also touched by some of the three neil patches in letux-base, I will first check what is up with the other ones. Regards, Andreas
pgplPJKRwUvbq.pgp
Description: OpenPGP digital signature
_______________________________________________ Gta04-owner mailing list [email protected] http://lists.goldelico.com/mailman/listinfo.cgi/gta04-owner
