On 09/22/2009 02:59 PM, Denys Vlasenko wrote: > I looked into the code just now. I wanted to check, maybe > I'm really horribly wrong? Maybe it's a beautifully > tight, slim and efficient code after all? > > This is an example I found in about 2 minutes: [...] > > These DBUS_TYPE_BYTE_AS_STRING are one-char strings. > You compare a dozen of them using strcmp. This is both slow > and bloaty.
If you'd actually like to get a constructive response, you might consider being constructive yourself, rather than copping an attitude and being insulting. Maybe something along the lines of this: "I found this bit of code in file X, function Y, and I think there might be a better/faster way. Here's a patch showing what I mean." Otherwise it makes it look like you're just here to rant, which isn't exactly the best way of influencing people. Just some friendly unsolicited advice... -brian _______________________________________________ gtk-devel-list mailing list gtk-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/gtk-devel-list