On Mon, Jan 12, 2015 at 1:30 PM, Philip Withnall <phi...@tecnocode.co.uk> wrote: > On Sun, 2015-01-11 at 16:43 +0000, Emmanuele Bassi wrote: >> hi; >> >> thanks for your patches. GTK+ does not use the mailing list to track >> bugs and patches; could you please open bugs on Bugzilla, instead? >> >> just use: https://bugzilla.gnome.org/enter_bug.cgi?product=gtk%2B >> >> this will make it easier for us to track the issue, review the code, >> and commit the change. > > This looks similar to (but not the same as) the patches I posted from > analysing GTK+ with Clang static analyser in November, which are still > awaiting review. > > I really hope we aren't going to end up with duplicate bug reports and > duplicate patches because things are not getting reviewed. :'-( > > https://bugzilla.gnome.org/show_bug.cgi?id=712760 >
I can't say that I agree with them being very similar. Most of Maks' patches were small, to the point, obvious oversight fixes that could be reviewed in a minute, each. The static analysis 'fixes' are an endless stream of mind-numbing can-never-happen corner cases of dubious value. Just IMO, of course :-) _______________________________________________ gtk-devel-list mailing list gtk-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/gtk-devel-list