On 08/02/2016 05:13 PM, Sébastien Wilmet wrote: > On Tue, Aug 02, 2016 at 01:47:41PM +0100, Philip Withnall wrote: >> On Mon, 2016-08-01 at 20:10 +0200, Sébastien Wilmet wrote: >>> So, is there an up-to-date Valgrind suppression file somewhere? Or is >>> GNOME.supp the most up-to-date? >> The one I’ve been using is here: >> >> https://github.com/pwithnall/walbottle/blob/master/libwalbottle/tests/w >> albottle.supp >> >> It covers most of the GLib and GIO functionality which I’ve been using >> recently. Enough to get the Walbottle tests Valgrind-clean, at least. >> >> I do not claim it’s anything like perfect though. > I already get much better results with walbottle.supp, at least for the > tests depending only on GLib/GObject. Thanks a lot! > >> This has been discussed before, and I failed to do anything about it: >> >> https://bugzilla.gnome.org/show_bug.cgi?id=666114#c28 >> >> Installing a suppression file with GLib won’t fix everything, because >> Valgrind only has one default suppression file, which we can’t modify >> or add to. So even if GLib installed a suppression file, you’d have to >> pass it as a --suppressions argument to Valgrind manually. However, >> that is better than having to write your own suppressions file //and// >> pass it in. >> >> See here for information about default.supp: >> >> https://wiki.wxwidgets.org/Valgrind_Suppression_File_Howto#Valgrind_and >> _suppression_files >> >> Valgrind has a couple of bugs open about improving its support for >> default suppressions. None of them have seen activity recently: >> >> https://bugs.kde.org/show_bug.cgi?id=93376 >> https://bugs.kde.org/show_bug.cgi?id=160905 (basically a duplicate) > And thanks for the links. I also think that it would be useful to have a > suppression file upstream, even if it is incomplete.
Sorry for reviving the thread. What if upstream lib ship a suppression file and add a pkg-config variable pointing to it? Then apps can use $PKG_CONFIG --variable=valgrind_suppressions gtk+-3.0 to collect those and e.g. export them into a valgrind wrapper or use them in the test runners. Stefan > > -- > Sébastien > _______________________________________________ > gtk-devel-list mailing list > gtk-devel-list@gnome.org > https://mail.gnome.org/mailman/listinfo/gtk-devel-list _______________________________________________ gtk-devel-list mailing list gtk-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/gtk-devel-list
