Quoting Jeroen Asselman <[EMAIL PROTECTED]> from ml.softs.gtk-gnutella.devel:
:However, Why isn't it allowed to have an int as ID? 

It's allowed.  The ID is just an opaque string.  It's just that seeing a
minus sign here makes me think that there might be parsing problems later.
Other PARQ implementations in other servents might use hexadecimal GUIDs.
Therefore, the ID must really be parsed back as an opaque string in the client
code: only the server must know the format of the IDs it generates.

:> Also I have 3 slots, and I had only one running uplaod, but GTKG was rejecting
:> the uploads with "too many uploads (3 max)" messages.  Clearly not correct.
:
:Well yes and no. There are multiple queues, depending on the number of
:upload slots so people who are requesting one small file don't need to
:wait for one downloading a rather large file.
:At the moment always one slot is reserved extra. But I will change it. I
:noticed it too, and I rarely have all 3 queues filled.

OK, the problem might be that the queues are not displayed in the GUI.
That's why it's harder to follow what's going on.

:> 
:> I further believe the HTTP header should not be:
:> 
:>     HTTP/1.1 503 Too many uploads (3 max) Queued at: 22, ETA: 8d 3h
:> 
:> but rather:
:> 
:>     HTTP/1.1 503 Queued (slot 22 / 45, ETA: 8d 3h)
:
:I'll change that too.

Thanks.  It's a cosmetic change, but it will also have the side effect
of making the Status shorter in the Uploads window...

About PARQ persistence: I think we should do something I had not thought
about before: treat the current uploading slots as PERSISTENT: give them
a position and a "queue ID" so that they can be "restarted" by the servent
in case of a crash (via QUEUE).  Also, a remote crash by the downloading
servent could be recovered by having that servent present the necessary
queue credentials that would perhaps not restore its upload slot, but at
least put him ahead in the queue.  Unless we accept to reserve slots upon
startup for recovery during 5 minutes, say.

To be able to do that, we have to enrich the reply we give to servents
that get a slot, so that they have a PARQ X-Queue and X-Queued information
as well.  Does that makes sense?  Is this is false good idea?

Raphael


-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en
_______________________________________________
Gtk-gnutella-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel

Reply via email to