-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
I have one question on the draft api,
What is 'eta' defined in reference to?
I have a few comments on the draft api,
1. There seems to be a mixing of Glib and plain C types with int, char*, GList*. IMHO, I think that using either plain C types or Glib types completely is better form.
2. Something that I wonder about is that a range_t is defined but not used everywhere it could be? In particular, event_upload_s, event_download_s.
3. Sizes of queues and files are defined using 'int' maybe they should be defined using 'size_t' or 'gsize' depending on the answer to 1.
4. The progress and speed variables in download_event_s, upload_event_s, upload_t, download_t should be represented as 'float' or 'gfloat'. I think that this makes it much more clear. If an int is used is it rounded to the nearest whole number? is it shifted up three places maybe four? I would like to avoid all that.
Otherwise, it looks good, Russ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQE/m867l8gE/LToDToRAhoRAKCmOw0FT024liFenTv+hpk89aoHtwCgs/30 TxFiyU8AY//gXFiKhZvzTLI= =T83R -----END PGP SIGNATURE-----
------------------------------------------------------- This SF.net email is sponsored by: The SF.net Donation Program. Do you like what SourceForge.net is doing for the Open Source Community? Make a contribution, and help us add new features and functionality. Click here: http://sourceforge.net/donate/ _______________________________________________ Gtk-gnutella-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
