Raphael Manfredi wrote:
> Quoting Christian Biere <[EMAIL PROTECTED]>
> from ml.softs.gtk-gnutella.devel:
> Well spotted!  I've removed the side effect in hostiles.c.

In this case you also want to fix the use of tolower() in fuzzy.c.

> I've kept the (fixed) code, but I'm not sure this trailing chopping of the
> whitespaces is really needed!

It's only interesting for removing the (possible) trailing newline for
the logging output. Technically, it's not necessary, no.

> I don't remember who authored that code though.

You don't have to. CVS keeps track of this. No, one else but me,
unless someone hacked the logs. ;-) I'd really be interested which
system has this problem because I always thought these "macros" have
to be safe and everywhere I looked the argument is only evaluated
once. Though, I think I'll prevent such constructs just to be on
the safe side.

Christian

Attachment: pgp00000.pgp
Description: PGP signature

Reply via email to