Hi folks,

I'm trying to get rid of a nasty bug in the Gtk1 frontend and in the
process am redefining the autoselection behaviour and simplifying the
code.

The old behaviour was rather strange and I don't want to explain it
completely now. What I want to do instead is to suggest how
autoselection should work in my opinion:

1) Autoselection of all sources of a file

I see little use in being able to select only one source of a file with
multiple sources. So I changed the code so that if one source of a file
is selected, all other sources are automatically also selected.

2) The "Autoselection" feature

>From ancient times we still have a autoselection feature that allows to
select files that are "similar" to each other. That means if the file
size is = or >= the selected and the filename is same or at lease
matches using a fuzzy algorithm. Actually I don't think we need those
features anymore, but I think we can leave them in in expert mode. They
should however be turned off by default. If the "autoselection" feature
is activated, the toggle "strict matching" decides wether the size of
a autoselected file must be = or >= the originally selected file and the
toggle "use fuzzy matching" decides wether the filenames must be
completely the same or only fuzzily match.


I have greatly simplified the autoselection code in the GTK1 GUI and I
think I have fixed that damn autoselection bug where memory would get
corrupted and gtkg would eventually crash when selecting a search
result. I will test this further though... that bug is very elusive
sometimes.

We should agree on an autoselection policy and define it (my suggestion
is above and seems to work quite well). After that the policy needs to
be implemented in both frontends.

If you want to test the above described behaviour before commenting,
please say so. I'll commit my changes to CVS then after I've tested it a
little more. If there are any comments in advance, feel free to speak.
-- 
Richard Eckart <[EMAIL PROTECTED]>



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
Gtk-gnutella-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel

Reply via email to