> > Hi,
> >
> > appended is a patch for GTKG that adds HSEP support to the GTK1 GUI.
> >
> > Change log:
> >
> > - added a "Horizon stats" frame to the GTK1 Gnet stats panel, which
> > displays the reachable nodes, files and bytes within 1 to 10 hops
> > (updated as often as the other stats on the stats panel)
>
> Why not add this info in the gnutellaNet pane next to the node
> connection where also the number of Queries, Rx, TX etc is displayed.
If I understand you correctly, this would mean displaying the
per-connection data. Currently, only the global data (that is, the
data accumulated over all connections) is displayed in the Gnet stats
panel. I'm not sure how the per-connection data would fit on the
gnutellaNet connections panel anyway. You would have to display a 10
rows x 3 columns clist for each connection. Or you could display the
horizon stats of a connection for a fixed number of hops (e.g. 5)
instead of for all hops.
It would be good to also display the per-connection data, but IMO this
has a (much?) lower priority than displaying the global data.
> Perhaps it would also be nice to have the number of files and bytes
> displayed in the lower left pane where currently the number of
> connections, uploads and downloads are displayed.
This would also be an option. But as above, you would have to choose a
fixed number of hops to display, otherwise the data won't fit there.
> Question:
> if (!hsep_check_monotony((hsep_triple *) messaget, max)) {
> - printf("HSEP: Node %p's message's monotony check failed", n);
> Is this an error due to invalid parsing or does this happen when we
> receive an invalid packet. If it is the last, it might be better to
> have it only printed when dbg is set. -> if (dbg) -> print
This is a sanity-check for an incoming packet, so it checks for
invalid packets. We could use checking dbg before printing, right.
> If it is invalid parsing while the packet is correct it should assert
> (I think).
It is not a check for an internal implementation problem, so an
assertion is not necessary there.
> It looks like some lines are wider then 80 chars, please use a maximum
> width of 80.
You're right about that. Could you please fix this (should be around 5
lines)?
How about providing a script that checks a source file for violations
of the GTKG style guide? ;)
Greetings,
Thomas.
-------------------------------------------------------
This SF.Net email is sponsored by the new InstallShield X.
>From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504
_______________________________________________
Gtk-gnutella-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
