Hi, Chris Winne wrote: > This happened once before that I am aware of (June 2004), where upon > restart, a complete rebuilding of the sha1_cache database is completely > rebuilt, resulting in the modification of file atime to startup time. At > that time, it was a change in shared.c. As I use the file atime to 1) > remove files that have not been downloaded for a significant period of > time, and 2) make sure I do not remove a file that may have been > accessed in the near past (in case the download is not complete), this > behaviour is rather inconvenient for me and seems inconsistent with the > file_mtime field of sha1_cache. Hopefully this was an oversight and not > by design. It happens everytime gtk-gnutella is started, not just after > the new update.
nice catch. As I mount everything with "noatime" I wouldn't have noticed this anyway. It wasn't as bad as the previous bug though because the SHA-1 wasn't recalculated. The modification time field wasn't initialized (or rather zero-filled) after some restructuring a couple of weeks ago. Therefore, the file was checked whether it's a partial file and *then* the modification time was set preventing a repeated SHA-1 calculation. I *did* notice that file scanning was much slower but unfortunately I blamed it on a mount option I added to some partitions (by incident at the same day it seems) and didn't even think of a bug. > I am currently at the 9/23/06 r12111 release of unstable (with gtk2). > As of the 9/14/06, r11988 (gtk1) release, the behaviour was as I would > expect, with only new files reread. Thanks, this was easy to find due to the information you provided. -- Christian ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Gtk-gnutella-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
