>From: Christian Biere <[EMAIL PROTECTED]>
>Reply-To: [email protected]
>To: [email protected]
>Subject: Re: [Gtk-gnutella-devel] Patch: Extensions to remote shell
>Date: Thu, 2 Nov 2006 06:40:56 +0100
>
> > "close" - closes Gnet connections
> > "open" - opens Gnet connections
>
>I changed those names to "offline" and "online" because close/open is a bit
>too
>generic for a top-level command.
They were *originally* "online" and "offline" - I changed them to "open" and
"close", to reflect the idea of "open to Gnet connections" and "closed to
Gnet connections". I'm notorious for overthinking things sometimes....
> > "props" - displays all available properties
>
>I kept that as is, because "properties" is really a bit long. I also
>extended
>it so that you can optionally pass a regex pattern to list only certain
>properties. This is something I've really missed several times when I
>wanted to
>modify some property but couldn't remember its exact name.
YES!!!!!
> > "stat" - a one-page status report for the node
>
>I renamed this to "status". I think it's not worth the 2 characters.
I *thought* about that - laziness won...
> > Note2: One thing I am moderately unhappy about is that I had to add a
> > global variable (only visible within shell.c) to capture the current
>time -
>
>Just use tm_time(). It returns a cached timestamp. See lib/tm.[ch] for
>related functions.
Ouch - I was so fixated on the "properties" that I didn't even check if
there was a library function for it. Methinks it's time for some source
code reading before I move on to more changes.
Lloyd Bryant
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Gtk-gnutella-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
