Matthew Lye wrote: > 1) Would the following substitution [which seems to work] be > acceptable? It seems to solve my problem. > > -2297 if (!GTK_WIDGET_HAS_FOCUS(GTK_WIDGET(clist))) > gtk_clist_moveto(clist, row, 0, 0.0, 0.0); > > +2297 if ( gtk_clist_row_is_visible(clist, row) != > GTK_VISIBILITY_FULL) > gtk_clist_moveto(clist, row, 0, 0.0, 0.0);
Thanks. I've committed your fix to SVN. > 2) What's going on with the "! GTK_WIDGET_HAS_FOCUS" conditional > "gtk_ctree_node_moveto()" functions in the following places? I tried > changing them into straight visibility tests as above, and then > finally tried removing them; nothing I did seemed to change the > behavior of the GUI in any way. I'm mainly just curious, but someone > might want to review them. > > > a) in "src/ui/gtk/gtk1/search.c": > 2366 if (!GTK_WIDGET_HAS_FOCUS(GTK_WIDGET(ctree))) > gtk_ctree_node_moveto(ctree, node, 0, 0.0, 0.0); > > b) in "src/ui/gtk/main_cb.c": > > 378 if (!GTK_WIDGET_HAS_FOCUS(GTK_WIDGET(ctree))) > gtk_ctree_node_moveto(ctree, node, 0, 0.0, 0.0); > > The documentation makes it sound like gtk_ctree_node_is_visible(), > the closest analog to the function that worked for me above, cannot > guarantee that the node itself will actually be within the viewable > container bounds. As far as I can tell, it can't ... but I'm unsure > of whether I've actually seen the code change execute. The point of using !GTK_WIDGET_HAS_FOCUS() is that cursor should not be modified if it's already inside this widget because it would be awkward if an items moves around (even if just slightly) as soon as you click on it. -- Christian ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Gtk-gnutella-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
