Christian Biere wrote: > > Lloyd Bryant wrote: >> I just tried updating to current SVN. It reports revision 14681, and the >> only file that was updated is "src/ui/gtk/gtk1/fileinfo.c" (since I'm using >> GTK2, changes to this file shouldn't affect anything). So yes - I am as >> certain as I can be that the issue is with r14680. > > Okay, this wasn't noticable for me with files that were at most a few MiB > large because hashing finishes under a second then and the final status > text should be correct. Anyway, I think I've found the bug now and it > should no longer display "SHA-1 check failed" during the verification. >
gtk-gnutella/0.96.5u-14978 (2007-09-28; GTK2; Linux i686 Sorry to "raise the dead", but this bug made a re-appearance today, under special circumstances: 1. Completed a download normally (it was a moderately large file - 350MiB). 2. SHA1 check on the file failed. 3. GtkG correctly identified the bad blocks, and downloaded replacements (The TTH capability is *awesome*). 4. The SHA1 was then re-calculated. While the *second* SHA1 calculation was in progress, the file download showed status of "SHA1 failed" rather than "Calculating SHA1". Looks like there's another instance of the bug in the section of code that resumes the SHA1 check after the TTH code has triggered additional downloads to fix bad chunks. Lloyd B. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ gtk-gnutella-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
