On Nov 15, 2012, at 10:57 AM, Behdad Esfahbod <[email protected]> wrote:
> Can you do a quick grep in Evolution, gnome-print, and possibly other modules, > to make sure no one was relying on those things being defined as macros? I > remember when I introduced those macros, I used conditionals in a couple > modules to use them. That would be weird, given the nature of the symbols -- they're always defined if Pango is included, and they're test values (e.g, if (pango_glyph == PANGO_GLYPH_EMPTY). But OK. I checked Evolution, gtk, and atk (libgnomeprint was deprecated years ago and its API moved into gtk). None of the PANGO_GLYPH symbols are used at all. Regards, John Ralls > On 12-11-14 05:02 PM, John Ralls wrote: >> commit 7274bd56db3ce2f02594687a307d22aa99c787c4 >> Author: John Ralls <[email protected]> >> Date: Mon Nov 12 19:38:30 2012 -0800 >> >> Make PANGO_GLYPH flags an enum to make gobject-introspection happy. >> >> See bug 688356 >> >> pango/pango-font.h | 10 ++++++---- >> 1 files changed, 6 insertions(+), 4 deletions(-) >> --- >> diff --git a/pango/pango-font.h b/pango/pango-font.h >> index eea27b4..ce1a421 100644 >> --- a/pango/pango-font.h >> +++ b/pango/pango-font.h >> @@ -374,10 +374,12 @@ struct _PangoFontClass >> #define PANGO_UNKNOWN_GLYPH_HEIGHT 14 >> >> #endif /* PANGO_ENABLE_BACKEND */ >> - >> -#define PANGO_GLYPH_EMPTY ((PangoGlyph)0x0FFFFFFF) >> -#define PANGO_GLYPH_INVALID_INPUT ((PangoGlyph)0xFFFFFFFF) >> -#define PANGO_GLYPH_UNKNOWN_FLAG ((PangoGlyph)0x10000000) >> +enum >> +{ >> + PANGO_GLYPH_EMPTY = ((PangoGlyph)0x0FFFFFFF), >> + PANGO_GLYPH_INVALID_INPUT = ((PangoGlyph)0xFFFFFFFF), >> + PANGO_GLYPH_UNKNOWN_FLAG = ((PangoGlyph)0x10000000), >> +}; >> #define PANGO_GET_UNKNOWN_GLYPH(wc) >> ((PangoGlyph)(wc)|PANGO_GLYPH_UNKNOWN_FLAG) >> >> >> _______________________________________________ >> commits-list mailing list (read only) >> https://mail.gnome.org/mailman/listinfo/commits-list >> >> Want to limit the commits to a few modules? Go to above URL, log in to edit >> your options and select the modules ('topics') you want. >> > > -- > behdad > http://behdad.org/ _______________________________________________ gtk-i18n-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/gtk-i18n-list
