> On Jan 9, 2022, at 4:51 AM, Pascal <p....@orange.fr> wrote:
>
> Hello,
>
> When building:
>
> % sh gtk-osx-setup.sh
> % PATH=.new_local/bin:$PATH
>
> % jhbuild bootstrap-gtk-osx
> % jhbuild build pygments
> % jhbuild build meta-gtk-osx-bootstrap
>
> An error occurs: ninja is not found.
>
> It happens that .new_local/bin is not appended to PATH before running the
> original jhbuild.
> Thus I propose to add it when creating local jhbuild:
>
> --- ./gtk-osx-setup.sh.0 2022-01-04 21:43:05.000000000 +0100
> +++ ./gtk-osx-setup.sh 2022-01-09 13:33:04.000000000 +0100
> @@ -188,7 +188,7 @@
> export PIPENV_PIPFILE="$DEVPREFIX/etc/Pipfile"
> export PYENV_ROOT="$PYENV_ROOT"
> export PYENV_VERSION="$PYENV_VERSION"
> -export PATH="$PYENV_ROOT/shims:$PATH"
> +export PATH="$PYENV_ROOT/shims:$DEVPREFIX/bin:$PATH"
> export CARGO_HOME="$CARGO_HOME"
> export RUSTUP_HOME="$RUSTUP_HOME"
> export WORKON_HOME="$WORKON_HOME"
>
> What is your feedback?
>
Instead of
PATH=.new_local/bin:$PATH
you need to say
export PATH="$HOME/.new_local/bin:$PATH"
otherwise it has effect for only that line.
Adding the path export to $DEVPREFIX/bin/jhbuild would require invoking jhbuild
with ~/.new_local/bin/jhbuild because it's not on the path. I think it's better
to have the user set the path in their shell rc file. I think install scripts
like Rust's that do that for the user are annoying. That's why gtk-osx-setup.sh
issues a warning instead of adding it.
Regards,
John Ralls
_______________________________________________
gtk-osx-users-list mailing list
gtk-osx-users-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-osx-users-list
