On Mon, Oct 7, 2019 at 3:04 AM Thierry Vignaud via gtk-perl-list
<gtk-perl-list@gnome.org> wrote:
> The commited fix results in:
> *** Poppler::Document::new_from_data: passed too many parameters
> (expected 3, got 4); ignoring excess at t/arrays.t line 204.
> need an array ref to convert to GArray at t/arrays.t line 204.
In addition to the above test error if you *do* have Poppler
installed, the value for skipping the new Poppler tests was set to
'1', as in "skip one test", and there's actually 16 Poppler tests that
need to be skipped if the Poppler library is not installed. The
attached patch fixes the test count. If nobody sees any problems with
it, I'll commit it, and wait for a decision and/or patch that takes
care of the above param count error before releasing G:O:I 0.048.
Thanks,
Brian
diff --git a/t/arrays.t b/t/arrays.t
index 5358cee..36a742b 100644
--- a/t/arrays.t
+++ b/t/arrays.t
@@ -190,7 +190,7 @@ SKIP: {
package => 'Poppler');
1;
};
- skip 'flat array tests using Poppler', 1
+ skip 'flat array tests using Poppler', 16
unless $have_poppler;
my $pdf = <<__PDF__; # https://github.com/mathiasbynens/small/blob/master/pdf.pdf
_______________________________________________
gtk-perl-list mailing list
gtk-perl-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-perl-list
