Axel Simon <axel.si...@in.tum.de> writes:

> On Apr 23, 2010, at 19:31, Andy Stewart wrote:
>
>> Hi Axel,
>>
>> I have finish below Cabal packages:
>>
>>    glade, gtkglext, gtksourceview2, soegtk, svgcairo, vte, webkit.
>>
>> Just gio, gstreamer, gconf haven't finish (i don't know how to fix
>> gconf, see my another mail).
>>
>> Please tell me when you finish above packages.
>> Then we split non-core packages out from main repository.
>>
>> Or i push non-core packages to main repository now?
>>
>
> I don't think I will find time this weekend to do the other packages.
>
> Could you send the patches to the list rather than push them directly. Then I 
> can review them.
Ok, i will. :)

>
> The post-commit hook is broken at the moment so nobody actually sees what's 
> being committed.
>
> I've now really pushed the patches that separate the internal functions of 
> gtk into a new module.
I have check your patches, you create GtkInternals, good.
but i found some problems that can't fix:

(1) Graphics.UI.Gtk.General.Threading
    When build-tools generate Signals.chs, it will add 
        import Graphics.UI.Gtk.General.Threading
    in Signals.chs, and Graphics.UI.Gtk.General.Threading is hidden in 
gtk.cabal.
    So all Signals.chs for other library can't compile pass.
    
(2) Graphics.UI.Gtk.Types
    When build-tools generate Types.chs, it will add 
        {#import Graphics.UI.Gtk.Types#}
    in Types.chs, and Graphics.UI.Gtk.Types is hidden in gtk.cabal.
    So all Types.chs for other library can't compile pass.
    
Maybe you need add "import Graphics.UI.Gtk.General.Threading" in GtkInternals,
then generate "import Graphics.UI.GtkInternals" in Signals.chs and Types.chs 

After above fix, i will test it with my project, some code is break
(Graphics.UI.Gtk.General.Structs, toNativeWindowId, fromNativeWindowId), 
we need do much work on re-export.

Cheers,

  -- Andy

------------------------------------------------------------------------------
_______________________________________________
Gtk2hs-devel mailing list
Gtk2hs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gtk2hs-devel

Reply via email to