Murray Cumming wrote: > On Thu, 2007-12-13 at 10:13 -0500, José Alburquerque wrote: > >> Murray Cumming wrote: >> >>> bool query_position(Format& format, ClockTime& position) >>> >>> Why the change of type for position? Is that an error in the gstreamer C >>> API? >>> >>> >>> >> While working on the element query example (GADM 11.1 >> <http://gstreamer.freedesktop.org/data/doc/gstreamer/head/manual/html/chapter-queryevents.html#section-querying>), >> >> I noticed that, although gst_element_query_position() works with a >> gint64, the C macros used with the position (like GST_TIME_ARGS and >> GST_FORMAT_TIME in gstclock.h) imply that they are working with a >> GstClockTime. Since C++ is strongly typed and C is not, I'm thinking >> that the developers used gint64 and GstClockTime interchangeably. In >> C++ types are more enforced so I thought we might use Gst::ClockTime >> instead, but this might not be the best thing to do. What do you think? >> > > Yes, that sounds like a good idea, but could you file a patch for > gstreamer to make their API clearer. That would be one way to be sure. > > There are quite a few places where gint64 is used instead of GstClockTime. I'm modifying to submit a patch. I take it that it's important to help clear up gstreamer code as we wrap also. Right?
-Jose _______________________________________________ gtkmm-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/gtkmm-list
