On Tue, 2013-03-26 at 11:30 +0100, Murray Cumming wrote: > On Mon, 2013-03-25 at 22:16 -0400, José Alburquerque wrote: > > 3) From the GTlsFileDatabase docs [5] (see the description and the class > > details), it seems that the interface derives from the GTlsDatabase > > class. In glibmm it therefore presently derives from Gio::TlsDatabase. > > I just want to make sure that the derivation of the interface in glibmm > > should not be changed. > > This is also odd. GTlsFileDatabase is an interface, that requires the > GTlsDatabase object type (not an interface). > > You have GTlsDatabase deriving from, and implementing, TlsFileDatabase > (and Object), which seems wrong, so I have corrected that: > https://git.gnome.org/browse/glibmm/commit/?id=6b966ecb0435775f6a7f84dece93b779b7ee42d3 > (Please check that you agree.)
I do. I think I got confused with the description of GTlsFileDatabase: "GTlsFileDatabase is implemented by GTlsDatabase objects which load their certificate information from a file. It is in interface which TLS library specific subtypes implement." I had not remembered that a type's prerequisite would list types that it would derive from and not the other way around, sorry. > > Actually, GTlsFileDatabase does not seem to be used in any public glib > or glibmm API (though TlsDatabase is). I suggest that we do not wrap it > just yet, to avoid us getting it wrong before we know how it should > really be used. That's fine. I've removed TlsFileDatabase from the list of sources to be built: https://git.gnome.org/browse/glibmm/commit/?id=e28f5093dced2e8cafef5795c02657b7265b78ca I guess it can be re-added (and maybe modified) in the future when it is more clear how the class should be used. -- José _______________________________________________ gtkmm-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/gtkmm-list
