On Fri 09 Jul 2010 08:23, No Itisnt <[email protected]> writes:
>> Looks good; a couple of comments inline. If you want to kill trailing >> whitespace, though, please do that as a separate commit, without any >> functional changes > > How do you reconcile that with 'delete-trailing-whitespace? I don't, really. I don't use that mode. It's better to respect the original source, so that the diffs and annotations aren't just noise... Of course if you trawl through *my* commits, you would find counter-examples to this "principle", so I guess there's a trade-off? >> Here we should produce a warning, I think, even if we are >> "permissive". Also please move the trailing parens to the previous >> line. > > Is there a standard way to do this? Presumably it will be printed on > *current-warning-port*, but any specific formatting guidelines or > anything? Unfortunately no guidelines, no. If you make some up, we'll use them though :) Andy -- http://wingolog.org/
