Hi Neil, Thanks for the review!
On Thu 28 Apr 2011 20:12, Neil Jerram <n...@ossau.uklinux.net> writes: > +@example > +(while #f (error "not reached")) @result{} #f > +(while #t (break)) @result{} #t > +(while #f (break 1 2 3)) @result{} 1 2 3 > +@end example > > I think the #f in the last while line should be #t. Indeed, fixed. > (if (pair? do-script) > (set-car! do-script arg)) > (set! arg0 arg) > (set! interactive? #f) > (finish args > (cons `(load ,arg) out))) > > Does this code mean that we load the script twice, in the -ds case? I think so, yes; unfortunately. Fixed. Would this merit a quick 2.0.2, you think? > > If that's right, I believe the -s block has the same issue. > > ((string=? arg "-x") ; add to %load-extensions > (if (null? args) > (error "missing argument to `-L' switch")) > (set! user-extensions (cons (car args) user-extensions)) > (parse (cdr args) > out)) > > In the error message here, -L should be -x. Fixed also. > Do we go interactive after seeing a -e option? I don't see a setting of > the interactive? variable that would prevent this? This appears to be the old behavior. Am I mistaken? Thanks, Andy -- http://wingolog.org/